Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise PhpUnit to ^10.5 + Improve CI + Remove asset-packagist.org usage #238

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 7, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Jan 7, 2024

PR Summary

  • Update to .gitignore File

    • The comments are modified for better readability, and a new entry ".phpunit.result.cache" is added to ignore cache files.
  • Modify PHP Testing Library in composer.json

    • The PHPUnit library used for testing is updated from version 9.4 to 10.5. The "repositories" field has been removed.
  • Improvements to PHPUnit Test Configurations

    • In the phpunit.xml.dist file, changes are implemented to align with the newer PHPUnit version along with added configurations to control behavior of test runs.
  • Adoption of Newer PHPUnit Syntax in Test Files

    • Several updates reflecting the newer version of PHPUnit are made in test files such as FilesystemStreamCollectorTest.php and HttpStreamCollectorTest.php. For example, the testing annotations are replaced with attribute-based annotations.
  • Refactoring of Testing Files

    • The AbstractStorageTest.php file has been renamed to AbstractStorageTestCase.php for better clarity and test files like FileStorageTest.php, MemoryStorageTest.php extend from this renamed reference.

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b1263c) 85.36% compared to head (776a8db) 76.13%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #238      +/-   ##
============================================
- Coverage     85.36%   76.13%   -9.23%     
  Complexity      585      585              
============================================
  Files            40       48       +8     
  Lines          1804     2024     +220     
============================================
+ Hits           1540     1541       +1     
- Misses          264      483     +219     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik changed the title Raise PhpUnit to ^10.5 + Remove asset-packagist.org usage Raise PhpUnit to ^10.5 + Improve CI + Remove asset-packagist.org usage Jan 7, 2024
@vjik vjik requested a review from a team January 7, 2024 10:50
@vjik vjik added the status:code review The pull request needs review. label Jan 7, 2024
@vjik vjik merged commit d39ffff into master Jan 7, 2024
19 of 20 checks passed
@vjik vjik deleted the improve branch January 7, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants